Fix edge cases of hwp offcenter correction #1386
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug of offcentering correction.
offcentering correction is done by taking average of two encoder data. Previous method was not making sure that two encoder data are aligned in time domain. In some observations (~20), previous correction was taking average of different rotations and leading to incorrect ver3 hwp angle. This was not introducing major issues in observations with constant speed, but this was introducing non-negligible bias in spin up observations.
Details: https://simonsobs.atlassian.net/wiki/spaces/PRO/pages/1248657450/Tau+HWP+debug#250922-validation-of-offcenter-fix
Since the number of observations affected by this issue is small, I plan not to update metadata version. I plan to re-run the solution for those observations.